Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update version.go in releaser github workflow #329

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Feb 3, 2024

Resolve #307.

@rominf rominf requested a review from a team February 3, 2024 21:31
@rominf
Copy link
Contributor Author

rominf commented Feb 3, 2024

Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good stuff

@Serpentiel Serpentiel self-assigned this Feb 5, 2024
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the generated commit compliant with the Conventional Commits

@rominf rominf force-pushed the rominf-version.go branch from a355f9a to 4ac9ce5 Compare February 5, 2024 09:35
@rominf
Copy link
Contributor Author

rominf commented Feb 5, 2024

@Serpentiel I was not sure what to put as a prefix. Is:

chore(version.go): update aiven-go-client version

good enough?

@rominf rominf requested a review from Serpentiel February 5, 2024 09:37
@rominf rominf dismissed Serpentiel’s stale review February 5, 2024 09:38

Comment addressed

Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel merged commit 4cc4312 into aiven:main Feb 5, 2024
4 checks passed
@rominf rominf deleted the rominf-version.go branch February 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version.go is not bumped during autorelease
2 participants